DAFNI Workflow Enhancements #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 27 27
Lines 1593 1593
=======================================
Hits 1495 1495
Misses 98 98 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jmafoster1
reviewed
Dec 11, 2024
jmafoster1
reviewed
Dec 11, 2024
f-allian
commented
Dec 11, 2024
jmafoster1
reviewed
Dec 11, 2024
jmafoster1
reviewed
Dec 11, 2024
# Conflicts: # dafni/src/main_dafni.py
There was a problem hiding this comment.
Pull Request Overview
This PR introduces enhancements to the DAFNI workflow to improve usability and reproducibility. Key changes include:
- Storing variable metadata directly in the dot file and removing the standalone variables.json argument.
- Converting main_dafni.py into a module to facilitate local testing.
- Updating CI/CD workflows and docker-compose configurations for improved build and test processes.
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dafni/model_definition.yaml | Updated metadata with additional attributes and a modified URL. |
| dafni/main_dafni.py | Removed the standalone entry point to favor modular testing. |
| dafni/docker-compose.yaml | Adjusted the Dockerfile path and volume mount changes. |
| dafni/README.md | Revised directory hierarchy documentation to reflect changes. |
| .github/workflows/publish-to-dafni.yaml | Added dependency installation and test execution steps prior to container build. |
Files not reviewed (5)
- dafni/Dockerfile: Language not supported
- dafni/data/inputs/causal_tests.json: Language not supported
- dafni/data/inputs/dag.dot: Language not supported
- dafni/data/inputs/variables.json: Language not supported
- dafni/data/outputs/causal_tests_results.json: Language not supported
Comments suppressed due to low confidence (1)
dafni/model_definition.yaml:2
- The updated URL now includes a percent-encoded space. Please verify that this is the intended URL and that it resolves correctly.
+# https://docs.secure.dafni.rl.ac.uk/docs/How%20to/how-to-write-a-model-definition-file
jmafoster1
reviewed
Apr 3, 2025
# Conflicts: # dafni/main_dafni.py
jmafoster1
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements to the DAFNI workflow that enables better usability and reproducibility. These include:
variables.jsonas an argument. The variables can now be stored as metadata attributes in thedotfile produced by the user.main_dafni.pyinto a module, which improves the modularity and testability of the entrypoint in the test suite.